Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
[ji] deterministic Java bean-style method aliases #4435
discovered during the investigation of #4432 (this addresses a different issue)
turns out the priority logic for setting up Java methods into Ruby land did not handle potential alias-ing conflicts for getters (same priority).
this test would periodically fail (more on travis-ci than locally always using the same JVM installation) ... JRuby already dealt with the non-determinstic case get/is issue before while generating wrappers: #3470
here we're making sure we always do the same setup for (unusual) cases with multiple getters for the same property e.g. getFoo() and isFoo() :
currently we're nondeterministic and depend on reflected method order foo -> getFoo method shall always win, since foo? is there for isFoo in case both getFoo and isFoo are specified the update should align nicely with expectations in #3470 due compatibility we can not fix #4432 isAnnotation() + getAnnotation(param) case is different since the get method isn't a (real) getter (and we're avoding a clash due #3262)