New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GzipReader "position" update for #each and #each_line. #4447

Merged
merged 1 commit into from Jan 19, 2017

Conversation

Projects
None yet
2 participants
@manu-crealytics
Contributor

manu-crealytics commented Jan 19, 2017

No description provided.

@enebo enebo added this to the JRuby 9.1.8.0 milestone Jan 19, 2017

@enebo enebo merged commit dd801d7 into jruby:master Jan 19, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Jan 19, 2017

Member

@manu-crealytics huge bonus if you add something to test this in ruby/spec project.

Member

enebo commented Jan 19, 2017

@manu-crealytics huge bonus if you add something to test this in ruby/spec project.

@manu-crealytics

This comment has been minimized.

Show comment
Hide comment
@manu-crealytics

manu-crealytics Jan 19, 2017

Contributor

@enebo I had already done that as part of a different issue, that's why I discovered this bug ;)
Here the PR (already merged): ruby/spec#383

Contributor

manu-crealytics commented Jan 19, 2017

@enebo I had already done that as part of a different issue, that's why I discovered this bug ;)
Here the PR (already merged): ruby/spec#383

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Jan 19, 2017

Member

@manu-crealytics Thanks a ton then for fixing our issue after that!

Member

enebo commented Jan 19, 2017

@manu-crealytics Thanks a ton then for fixing our issue after that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment