Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Make sure to iterate over all keys when cancelling keys in a SelectorPool #4471
When we updated our server from 18.104.22.168 to 22.214.171.124 we started seeing a file descriptor leak which, if left for long enough, would run the machine out of file descriptors.
We tracked down the problem to #3952 which changed how SelectionKeys were closed.
It looks like if exceptions aren't caught while calling
When we went back to the same key cancelling code that was used in 126.96.36.199 the problem went away.
Hmm, what exceptions are being thrown at https://github.com/jruby/jruby/pull/4471/files#diff-f99fc044de4e2aa68b3bb1f212348b07R92 ? If the cancelling fails for some reason and the
@cheister yeah could you put in logging to see what the exceptions are, and also to check the status of