Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upImplemented optional buffer argument for Array#pack #4502
Conversation
| public RubyString pack(ThreadContext context, IRubyObject obj, IRubyObject maybeOpts) { | ||
| Ruby runtime = context.runtime; | ||
| IRubyObject opts = ArgsUtil.getOptionsArg(runtime, maybeOpts); | ||
| RubyString str = RubyString.newEmptyString(runtime); |
This comment has been minimized.
This comment has been minimized.
kares
Feb 24, 2017
Member
preferably use RubyString.newString() the newEmptyString is for cases such as return ''
| if (!opts.isNil()){ | ||
| IRubyObject buffer = ((RubyHash) opts).fastARef(runtime.newSymbol("buffer")); | ||
| if (buffer != null) { | ||
| str = (RubyString) buffer; |
This comment has been minimized.
This comment has been minimized.
kares
Feb 24, 2017
Member
maybe the RubyString allocation (above) can be delayed until its sure a buffer is not provided?
| } catch (ArrayIndexOutOfBoundsException e) { | ||
| throw concurrentModification(context.runtime, e); | ||
| } catch (ClassCastException e){ |
This comment has been minimized.
This comment has been minimized.
kares
Feb 25, 2017
Member
why is this introduced here? is it due the obj.convertToString() removal? (would keep it than)
This comment has been minimized.
This comment has been minimized.
whwilder
Feb 25, 2017
Contributor
In my original implementation I hadn't considered what would happen if the buffer were nil or some other class besides String. MRI Ruby throws a type error, and this seemed to be the most straightforward way of mirroring that behavior.
This comment has been minimized.
This comment has been minimized.
kares
Feb 25, 2017
Member
buffer.convertToString() will do that for you - raising a TypeError e.g. on nil
... ClassCastException isn't very bad but theoretically might happen from some other place
if you could update to get rid of it that would be great ... the rest of the code is great merge material!
whwilder commentedFeb 23, 2017
ref #4293