Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve some of the debug logging in ConstantLookupSite. #4504
Added this while debugging an issue, figured it'd be useful
Happy to change the format of the logs if there's any objections,
Added this while debugging an issue, figured it'd be useful upstream. Adds the method name to the log statement + adds logging for searchModuleForConst. Spelling out the method name is useful to distinguish between lexicalSearchConst and searchConst, but also makes it easier to map the log statements with the origin method when you're not familiar with the code.
@headius: Was able to track down the problem, so not gonna create an issue, but I'll outline it here: after updating from 220.127.116.11 to 18.104.22.168 we saw a large increase in time spent in ParNew (would hit 30% during peak hours after a few days, depending on the amount of traffic). We tracked down the issue to being introduced either in 1ae29af or d15e35a. Turns out your change to make the idTest on RubyModule lazy fixed the issue, so we're just going to patch that change in to .7. Would love to find out why creating redundant MethodHandles was causing increased GC pressure (memory leak?), but its not crucial at this point.