New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually cache the idTest on the module. #4507

Merged
merged 1 commit into from Feb 24, 2017

Conversation

Projects
None yet
2 participants
@snowp
Contributor

snowp commented Feb 24, 2017

This was assigning to the local variable, so the MethodHandle would be created ever time this is called.

Actually cache the idTest on the module.
This was assigning to the local variable, so the  would be created ever time this is called.
@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Feb 24, 2017

Member

D'oh. Wanted to avoid eagerly creating them and went too far. Thanks!

Member

headius commented Feb 24, 2017

D'oh. Wanted to avoid eagerly creating them and went too far. Thanks!

@headius headius added this to the JRuby 9.1.8.0 milestone Feb 24, 2017

@headius headius merged commit 74c5095 into jruby:master Feb 24, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment