Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actual impl module to test bindability. Fixes #4477. #4521

Merged
merged 1 commit into from Mar 3, 2017

Conversation

@headius
Copy link
Member

@headius headius commented Mar 3, 2017

This fixes #4477 by not using the origin module/class to test bindable hierarchy but instead using the actual implementation module. I'm not sure why it was doing the latter before, but it meant that any methods captured from a module were not bindable to class hierarchies that included that module (since the module was hidden behind a Prepended or IncludedModule origin).

This seems like the proper logic, but I'm doing it as a PR to check CI before pushing forward for 9.1.8.0.

There may be tests for this we don't pass but I could not find them.

@headius headius added this to the JRuby 9.1.8.0 milestone Mar 3, 2017
@headius
Copy link
Member Author

@headius headius commented Mar 3, 2017

Everything passed except for some newer flaky specs for Weakref. Merging.

@headius headius merged commit 33526ee into jruby:master Mar 3, 2017
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@headius headius deleted the headius:fix-4477 branch Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.