New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not set eval-type NONE value in a thread-local #4530

Merged
merged 3 commits into from Mar 18, 2017

Conversation

Projects
None yet
2 participants
@kares
Member

kares commented Mar 14, 2017

resolves #4529

a follow-up on #4215 + a FIXME fixed that I've bumped into way too often :)

... any chance to get this in for 9.1.9.0 - getting a lot of log on TC // cc @headius @enebo

@kares kares changed the title from do not set eval-type NONE in a thread-local to do not set eval-type NONE value in a thread-local Mar 14, 2017

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Mar 14, 2017

Member

@kares It seems ok to me but fix your bracing to match our style } else {

Member

enebo commented Mar 14, 2017

@kares It seems ok to me but fix your bracing to match our style } else {

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Mar 14, 2017

Member

@enebo done and thanks. there's an additonal commit: 91926ef ... figured that the BlockBody might not report the correct (previously set) eval-type when there's a jitted body (can remove if there's reason for that).

Member

kares commented Mar 14, 2017

@enebo done and thanks. there's an additonal commit: 91926ef ... figured that the BlockBody might not report the correct (previously set) eval-type when there's a jitted body (can remove if there's reason for that).

@kares kares added this to the JRuby 9.1.9.0 milestone Mar 14, 2017

@kares kares merged commit df15739 into master Mar 18, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kares kares deleted the test-null-eval-type-dejavu branch Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment