New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't yieldSpecific to allow arrays through normal block params. #4534

Merged
merged 1 commit into from Mar 17, 2017

Conversation

Projects
None yet
3 participants
@headius
Member

headius commented Mar 16, 2017

Fixes #4532.

@headius headius added this to the JRuby 9.1.9.0 milestone Mar 16, 2017

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Mar 17, 2017

Member

@headius wow that is literally the only yieldSpecific we have left in RubyEnumerable

Member

enebo commented Mar 17, 2017

@headius wow that is literally the only yieldSpecific we have left in RubyEnumerable

@headius headius merged commit b7f434d into jruby:master Mar 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@headius headius deleted the headius:fix-4532-each_entry branch Mar 17, 2017

@toy

This comment has been minimized.

Show comment
Hide comment
@toy

toy Mar 17, 2017

@headius I think some test of behaviour would be great to be sure that tweaking logic doesn't break it.

toy commented Mar 17, 2017

@headius I think some test of behaviour would be great to be sure that tweaking logic doesn't break it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment