Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AARCH64 support in FFI #4548

Merged
merged 2 commits into from Apr 19, 2017
Merged

Add AARCH64 support in FFI #4548

merged 2 commits into from Apr 19, 2017

Conversation

@yuqilinaro
Copy link
Contributor

yuqilinaro commented Mar 28, 2017

This PR is to add support for the AARCH64/ARM64 in JRuby FFI.

@yuqilinaro
Copy link
Contributor Author

yuqilinaro commented Apr 1, 2017

@ayappanec Is this patch ok to be merged for support for AArch64?
Could you please review it? thanks a lot!

@ayappanec
Copy link

ayappanec commented Apr 3, 2017

The PR looks good.

@yuqilinaro
Copy link
Contributor Author

yuqilinaro commented Apr 5, 2017

@headius Could you please check it? Thanks!

@@ -84,6 +84,7 @@
SPARCV9,
S390X,
ARM,
AARCH64,

This comment has been minimized.

@olleolleolle

olleolleolle Apr 5, 2017 Member

This is a tab, use spaces instead.

This comment has been minimized.

@ayappanec

ayappanec Apr 5, 2017

Interesting !. How did you figured this out ? by seeing the indentation ?

This comment has been minimized.

@olleolleolle

olleolleolle Apr 5, 2017 Member

The presentation was 1 character off in this view.

Then: Visiting "View", marking and dragging the cursor over and seeing that the visualization of the marked text "snapped" to a tab stop, not to individual spaces.

This comment has been minimized.

@ayappanec

ayappanec Apr 5, 2017

This is cool. Thanks for the info.

This comment has been minimized.

@yuqilinaro

yuqilinaro Apr 6, 2017 Author Contributor

@olleolleolle It's awesome! Thanks!

@guyuqi
Copy link
Contributor

guyuqi commented Apr 10, 2017

@enebo Could you please take your time to review this changes? Thanks!

@headius
Copy link
Member

headius commented Apr 19, 2017

Hello! Sorry this slipped a bit. Looking into merging.

@headius headius added this to the JRuby 9.1.9.0 milestone Apr 19, 2017
@headius headius merged commit e06bd07 into jruby:master Apr 19, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.