Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up structure of io/console and avoid stty on Windows. #4592

Merged
merged 1 commit into from May 8, 2017

Conversation

@headius
Copy link
Member

headius commented May 7, 2017

Fixes #3989.

  • Restructure the different impls of console into their own files.
  • Always use stubbed version on Windows.
  • Cascade from native to stty to stubbed on other platforms.

cc @kares @enebo @jmiettinen

Fixes #3989.

* Restructure the different impls of console into their own files.
* Always use stubbed version on Windows.
* Cascade from native to stty to stubbed on other platforms.
@headius headius added this to the JRuby 9.1.9.0 milestone May 7, 2017
@headius
Copy link
Member Author

headius commented May 7, 2017

@enebo Any concerns?

@enebo
Copy link
Member

enebo commented May 8, 2017

@headius no. Are you going to get this upstream too? Or parts of it at least?

@headius
Copy link
Member Author

headius commented May 8, 2017

@enebo Upstream where? This is JRuby-specific; in MRI io/console is a C ext. This change will go into both 9k and 1.7.

@headius headius merged commit e778b56 into jruby:master May 8, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@headius headius deleted the headius:cleanup_io_console_9k branch May 8, 2017
@enebo
Copy link
Member

enebo commented May 8, 2017

well I meant MRI and forgot it was a cext.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.