add multiple assignment support to java.util.Collection's Fixes #459 #460

Merged
merged 1 commit into from Mar 22, 2013

Projects

None yet

3 participants

@atambo
Member
atambo commented Dec 22, 2012

No description provided.

@nirvdrum
Contributor

Should this only work with java.util.List implementations? java.util.Set inherits from java.util.Collection, but Ruby doesn't exhibit the same multiple assignment behaviour with Sets, presumably because there is no ordering.

@atambo
Member
atambo commented Dec 22, 2012

@nirvdrum, what about a Queue where there is ordering but it is not a List?

@atambo
Member
atambo commented Dec 22, 2012

We'd also miss the SortedSet interface if we went List only. I feel like we should just do it for all collections since it will still work it just wont have any guarantees about order.

@nirvdrum
Contributor

Ahh, more corner cases. I guess I don't have a strong issue with it being on java.util.Collection, other than it doesn't have 1:1 parity with Ruby's Set. Since #459 seemed to be about deviating behaviour, I figured I'd mention that this breaks in a different (probably less important) way.

@headius headius merged commit ff74833 into jruby:master Mar 22, 2013

1 check passed

default The Travis build passed
Details
@headius
Member
headius commented Mar 22, 2013

Good fix, I like it. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment