New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UDPSocket#(send|write) to raise EMSGSIZE #4608

Merged
merged 4 commits into from May 24, 2017

Conversation

Projects
None yet
4 participants
@etehtsea
Contributor

etehtsea commented May 17, 2017

No description provided.

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares May 17, 2017

Member

one failure on spec:ruby:fast seems legit?

     [exec] 1)
     [exec] UDPSocket#write raises EMSGSIZE if msg is too long ERROR
     [exec] NoMethodError: undefined method `closed?' for nil:NilClass
     [exec] Did you mean?  clone
     [exec] /home/travis/build/jruby/jruby/spec/ruby/library/socket/udpsocket/write_spec.rb:18:in `block in (root)'
     [exec] org/jruby/RubyBasicObject.java:1687:in `instance_eval'
     [exec] org/jruby/RubyEnumerable.java:1596:in `all?'
     [exec] org/jruby/RubyFixnum.java:299:in `times'
     [exec] org/jruby/RubyArray.java:1734:in `each'
     [exec] /home/travis/build/jruby/jruby/spec/ruby/library/socket/udpsocket/write_spec.rb:4:in `<main>'
     [exec] org/jruby/RubyKernel.java:979:in `load'
     [exec] org/jruby/RubyBasicObject.java:1687:in `instance_eval'
     [exec] org/jruby/RubyArray.java:1734:in `each'
Member

kares commented May 17, 2017

one failure on spec:ruby:fast seems legit?

     [exec] 1)
     [exec] UDPSocket#write raises EMSGSIZE if msg is too long ERROR
     [exec] NoMethodError: undefined method `closed?' for nil:NilClass
     [exec] Did you mean?  clone
     [exec] /home/travis/build/jruby/jruby/spec/ruby/library/socket/udpsocket/write_spec.rb:18:in `block in (root)'
     [exec] org/jruby/RubyBasicObject.java:1687:in `instance_eval'
     [exec] org/jruby/RubyEnumerable.java:1596:in `all?'
     [exec] org/jruby/RubyFixnum.java:299:in `times'
     [exec] org/jruby/RubyArray.java:1734:in `each'
     [exec] /home/travis/build/jruby/jruby/spec/ruby/library/socket/udpsocket/write_spec.rb:4:in `<main>'
     [exec] org/jruby/RubyKernel.java:979:in `load'
     [exec] org/jruby/RubyBasicObject.java:1687:in `instance_eval'
     [exec] org/jruby/RubyArray.java:1734:in `each'
@etehtsea

This comment has been minimized.

Show comment
Hide comment
@etehtsea

etehtsea May 17, 2017

Contributor

Nope, I'll look into it.

Contributor

etehtsea commented May 17, 2017

Nope, I'll look into it.

@etehtsea

This comment has been minimized.

Show comment
Hide comment
@etehtsea

etehtsea May 18, 2017

Contributor

@kares fixed (I hope).

Contributor

etehtsea commented May 18, 2017

@kares fixed (I hope).

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares May 18, 2017

Member

👍 looks good to me ... not sure if we're to merge PRs yet since the 9.1.9.0 release is fairly recent

Member

kares commented May 18, 2017

👍 looks good to me ... not sure if we're to merge PRs yet since the 9.1.9.0 release is fairly recent

@kares kares added this to the JRuby 9.2.0.0 milestone May 24, 2017

@kares kares merged commit b04be74 into jruby:master May 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@etehtsea etehtsea deleted the etehtsea:4606-udp-emsgsize branch May 24, 2017

@dwbutler

This comment has been minimized.

Show comment
Hide comment
@dwbutler

dwbutler May 31, 2017

If you're relying on the OS returning an error message of Message too long, you might have a bad time. It seems that Debian distributions return the error message Message too large. (See dwbutler/logstash-logger#128)

If you're relying on the OS returning an error message of Message too long, you might have a bad time. It seems that Debian distributions return the error message Message too large. (See dwbutler/logstash-logger#128)

@etehtsea

This comment has been minimized.

Show comment
Hide comment
@etehtsea

etehtsea Jun 1, 2017

Contributor

@dwbutler according to this comment it look like Alpine specific issue.

Anyway it's possible to match both error messages.

P.S. I checked that it works properly on Debian Jessie.

Contributor

etehtsea commented Jun 1, 2017

@dwbutler according to this comment it look like Alpine specific issue.

Anyway it's possible to match both error messages.

P.S. I checked that it works properly on Debian Jessie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment