Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement Zlib::GzipReader #ungetbyte and #ungetc #4636
I've had a stab at implementing the
Let me know what you think!
@haines You may be right. Do you want to look into it? It may just be some missing logic in our ported GzipReader#gets implementation. I suppose the test passed before because it fell back on io#ungetc which didn't actually unget anything, so the subsequent gets worked properly.
Thanks for your help! I have some review comments I'll add.
I've added the specs, which caught a bug in my implementation (I forgot to decrement
I'll take a look at the
Jun 2, 2017
1 check passed
added a commit
this pull request
Jun 6, 2017
Either follow what MRI does, or raise a bug, but please not spec different behavior without a bug report.