Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Module inclusion order #4639

Merged
merged 3 commits into from Jun 6, 2017
Merged

Fix Module inclusion order #4639

merged 3 commits into from Jun 6, 2017

Conversation

@MSNexploder
Copy link
Contributor

@MSNexploder MSNexploder commented Jun 1, 2017

This fixes Module inclusion order as seen in #1938

@headius
Copy link
Member

@headius headius commented Jun 1, 2017

Failure appears to be directly related to the patch. Can you take a look into it?

@MSNexploder
Copy link
Contributor Author

@MSNexploder MSNexploder commented Jun 1, 2017

Will look into it. Looks like the whole Module thing is not as straightforward as I hoped. 😉

@MSNexploder MSNexploder force-pushed the MSNexploder:module_order branch from f4cd16f to a7aef67 Jun 3, 2017
@MSNexploder MSNexploder changed the title (re-)integrate pull request #2002 into JRuby 9k Fix Module inclusion order Jun 3, 2017
@MSNexploder
Copy link
Contributor Author

@MSNexploder MSNexploder commented Jun 3, 2017

Pretty sure I got the Module#prepend working again 🎉

@headius
Copy link
Member

@headius headius commented Jun 6, 2017

Well it passes tests...so I'll do a quick review and get it in! Thanks!

@headius
headius approved these changes Jun 6, 2017
@headius headius merged commit d47687a into jruby:master Jun 6, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@headius headius added this to the JRuby 9.1.11.0 milestone Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.