Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunch of fixes for IO.copy_stream #466

Merged
merged 5 commits into from Jan 21, 2013

Conversation

Projects
None yet
2 participants
@atambo
Copy link
Member

atambo commented Dec 30, 2012

No description provided.

@atambo

This comment has been minimized.

Copy link
Member Author

atambo commented Jan 21, 2013

@BanzaiMan, anything blocking this from being merged?

@ghost

This comment has been minimized.

Copy link

ghost commented Jan 21, 2013

I gave everything a cursory glance, and it seems ok. I think some of the changes in that last commit are a bit ... smelly.

enebo added a commit that referenced this pull request Jan 21, 2013

Merge pull request #466 from atambo/copy_stream_to_path
Bunch of fixes for IO.copy_stream

I will address Wayne's concerns after I merge this.

@enebo enebo merged commit 5fae685 into jruby:master Jan 21, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.