New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nil buffer in Zlib::GzipReader#readpartial #4673

merged 2 commits into from Jun 22, 2017


None yet
2 participants

haines commented Jun 16, 2017

In MRI it's ok to explicitly pass a nil buffer to #readpartial. However, JRuby currently throws a TypeError.

This adds a nil-check to bring JRuby in line with MRI's behaviour.

haines added some commits Jun 16, 2017

@kares kares added this to the JRuby milestone Jun 22, 2017


This comment has been minimized.


kares commented Jun 22, 2017

good catch, thanks.

@kares kares merged commit eef3f72 into jruby:master Jun 22, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error

@haines haines deleted the haines:gzip_reader_readpartial branch Jun 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment