Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix StrptimeLexer.flex to add a comment about how to generate the lexer #4674
Conversation
| @@ -10,7 +17,7 @@ | ||
| /** | ||
| * This class is a scanner generated by | ||
| * <a href="http://www.jflex.de/">JFlex</a> 1.4 | ||
| * on 5/6/17 4:40 AM from the specification file | ||
| * on 6/16/17 3:03 PM from the specification file | ||
| * <tt>core/src/main/java/org/jruby/lexer/StrptimeLexer.flex</tt> | ||
| */ | ||
| public class StrptimeLexer { |
This comment has been minimized.
This comment has been minimized.
muga
Jun 17, 2017
Contributor
I re-generated .java file. If we don't need the update, please let me know. I will remove it.
kares
reviewed
Jun 17, 2017
for the record: latest JFlex is 1.6.1 (almost 2y old) and has an official maven plugin.
This comment has been minimized.
This comment has been minimized.
|
@kares Thank you for reviewing and commenting. The latest JFlex is 1.6.1. As you know, the current |
This comment has been minimized.
This comment has been minimized.
|
I'm ignoring the CI failures because it seems that they're not related to this fix. |
This comment has been minimized.
This comment has been minimized.
|
Thank you for your continued improvements |
muga commentedJun 17, 2017
This PR comes from #4635 and fixes StrptimeLexer.flex to add a comment for how to generate the lexer.
Ideally we should not put those lexer java programs as @enebo and @headius discussed it on #4635 and will fix that on #4665.