Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StrptimeLexer.flex to add a comment about how to generate the lexer #4674

Conversation

@muga
Copy link
Contributor

@muga muga commented Jun 17, 2017

This PR comes from #4635 and fixes StrptimeLexer.flex to add a comment for how to generate the lexer.

Ideally we should not put those lexer java programs as @enebo and @headius discussed it on #4635 and will fix that on #4665.

@@ -10,7 +17,7 @@
/**
* This class is a scanner generated by
* <a href="http://www.jflex.de/">JFlex</a> 1.4
* on 5/6/17 4:40 AM from the specification file
* on 6/16/17 3:03 PM from the specification file
* <tt>core/src/main/java/org/jruby/lexer/StrptimeLexer.flex</tt>
*/
public class StrptimeLexer {

This comment has been minimized.

@muga

muga Jun 17, 2017
Author Contributor

I re-generated .java file. If we don't need the update, please let me know. I will remove it.

Copy link
Member

@kares kares left a comment

for the record: latest JFlex is 1.6.1 (almost 2y old) and has an official maven plugin.

@muga
Copy link
Contributor Author

@muga muga commented Jun 19, 2017

@kares Thank you for reviewing and commenting. The latest JFlex is 1.6.1. As you know, the current StrftimeLexer.flex and StrptimeLexer.flex work with JFlex 1.4 only (Not work with 1.4.1,.. 1.6.1). It's better that the current .flex files are ideally refactored and fixed for JFlex 1.6.1 and then, use jflex-maven-plugin to automatically generate .java files. I think that it would be done on #4665.

@muga
Copy link
Contributor Author

@muga muga commented Jun 19, 2017

I'm ignoring the CI failures because it seems that they're not related to this fix.

@headius
Copy link
Member

@headius headius commented Jun 21, 2017

Thank you for your continued improvements 👍

@headius headius merged commit cf88de7 into jruby:master Jun 21, 2017
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@headius headius added this to the JRuby 9.2.0.0 milestone Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.