Fix StrptimeLexer.flex to add a comment about how to generate the lexer #4674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muga
commented
Jun 17, 2017
| @@ -10,7 +17,7 @@ | |||
| /** | |||
| * This class is a scanner generated by | |||
| * <a href="http://www.jflex.de/">JFlex</a> 1.4 | |||
| * on 5/6/17 4:40 AM from the specification file | |||
| * on 6/16/17 3:03 PM from the specification file | |||
| * <tt>core/src/main/java/org/jruby/lexer/StrptimeLexer.flex</tt> | |||
| */ | |||
| public class StrptimeLexer { | |||
There was a problem hiding this comment.
I re-generated .java file. If we don't need the update, please let me know. I will remove it.
kares
reviewed
Jun 17, 2017
|
@kares Thank you for reviewing and commenting. The latest JFlex is 1.6.1. As you know, the current |
|
I'm ignoring the CI failures because it seems that they're not related to this fix. |
|
Thank you for your continued improvements 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes from #4635 and fixes StrptimeLexer.flex to add a comment for how to generate the lexer.
Ideally we should not put those lexer java programs as @enebo and @headius discussed it on #4635 and will fix that on #4665.