native implementation of set.rb #4690
Merged
Conversation
also to be noted that due use of Sets in Rails this has a noticeable impact on a decently sized Rails app. UPDATE: compared to 9.1.12 its still seems to be a consistent 5% improvement using this branch ... |
... with auto (magic) toJava conversions (like RubyArray does)
... wouldn't care really but this is spec-ed by RubySpecs
(and raises an ArgumentError with a more useful message)
... relaxed the respond_to?(:<=>) expectation as it seems less important
... necessary since we use some Java internal structures its been implemented in Java, could have been done with _load/_dump although would require exposing some of the Set/SortedSet internals
... and thus MRI's (pure Ruby) set.rb implementation as well important with Rails using Sprockets at its marshalling Set instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
work towards having
Set/SortedSet
natively instead ofset.rb
had these changes lying around for a long-time (mostly waiting to target 9.2)
primarily this has been motivated for premium Java Integration features :
Set implements java.util.Set
andSortedSet implements java.util.SortedSet
but there's also a significant gain in performance.
set.rb is rather loosely written with some ugly-ness such as patching/features-detection on
SortedSet.new
for maximum compatibility sets are backed by a
Hash
like before (and serializes the same as before), this is important for some older versions of Sprockets when under Rails switching between MRI and JRuby.SortedSet
uses Java'sTreeSet
implementation for ordering as it was available and performs better than the pieces in set.rbsome (naive) performance numbers, also showcasing
Set
is now at Java'sHashSet
speed :JRuby 9.1.9
MRI 2.3.3