/ jruby Public
native implementation of set.rb #4690
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
work towards having
Set/SortedSetnatively instead of
had these changes lying around for a long-time (mostly waiting to target 9.2)
primarily this has been motivated for premium Java Integration features :
Set implements java.util.Setand
SortedSet implements java.util.SortedSet
but there's also a significant gain in performance.
set.rb is rather loosely written with some ugly-ness such as patching/features-detection on
for maximum compatibility sets are backed by a
Hashlike before (and serializes the same as before), this is important for some older versions of Sprockets when under Rails switching between MRI and JRuby.
TreeSetimplementation for ordering as it was available and performs better than the pieces in set.rb
some (naive) performance numbers, also showcasing
Setis now at Java's