Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File.directory? should handle IO's #471

Merged
merged 1 commit into from Feb 28, 2013

Conversation

Projects
None yet
2 participants
@atambo
Copy link
Member

atambo commented Jan 2, 2013

The last failing tag for File.directory? is blocked by:

http://jira.codehaus.org/browse/JRUBY-4033

@ghost

This comment has been minimized.

Copy link

ghost commented Jan 2, 2013

I don't think we'll be fixing JRUBY-4033 anytime soon. I mean, we could use jnr-enxio to open directories as files, but then we'll be introducing a whole new boatload of potential compatibility problems.

More than I'd like to do in a point release anyway, but maybe we'll do it for JRuby-9k-BFG-Edition.

File.directory? and FileTest.directory? should handle IO's
The last failing tags for File and FileTest directory? are blocked
by http://jira.codehaus.org/browse/JRUBY-4033.
@atambo

This comment has been minimized.

Copy link
Member Author

atambo commented Feb 15, 2013

Well this fix should be good on it's own and if JRUBY-4033 is ever fixed there shouldn't need to be any code changes required for the last failing tags to start passing.

enebo added a commit that referenced this pull request Feb 28, 2013

Merge pull request #471 from atambo/file_directory
File.directory? should handle IO's

@enebo enebo merged commit 0311596 into jruby:master Feb 28, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.