Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Add missing `final`s and cleanup dead imports in `org.jruby.irinstructions.CallBase` #4742

Merged

Conversation

@original-brownbear
Copy link
Contributor

@original-brownbear original-brownbear commented Aug 17, 2017

Just two trivial things I found while researching something else:

  • Removed some dead imports
  • Added final to three fields that are never mutated anywhere to make this class a little easier to follow when trying to debug concurreny issues like #4739 :)
….instructions.CallBase`
@kares kares added the internal label Aug 21, 2017
@kares kares merged commit 2e6f9d9 into jruby:master Aug 26, 2017
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@kares kares added this to the JRuby 9.2.0.0 milestone Aug 26, 2017
@original-brownbear original-brownbear deleted the original-brownbear:cleanup-missing-finals-callbase branch Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.