New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: cleanup setting callcounts for JIT #4750

Merged
merged 1 commit into from Aug 26, 2017

Conversation

Projects
None yet
2 participants
@original-brownbear
Contributor

original-brownbear commented Aug 26, 2017

Just some trivial spots I found recently:

  • Some of those promoteToFullBuild (and analogously named) methods can be made private since they aren't used in child classes
  • Removed dead import import org.jruby.EvalType;
  • Fixed logger for MixedModeIRBlockBody (it was using the wrong class to bind to)
  • Removed two redundant sets of the callcount to -1 (callCount = -1; is not necessary since context.runtime.getJITCompiler().buildThresholdReached(context, this); will do this:
    public void buildThresholdReached(ThreadContext context, final Compilable method) {
        final RubyInstanceConfig config = context.runtime.getInstanceConfig();

        // Disable any other jit tasks from entering queue
        method.setCallCount(-1);

=> sets the -1 here either way.

@kares kares merged commit c60643a into jruby:master Aug 26, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@original-brownbear original-brownbear deleted the original-brownbear:cleanup-redundant-jit-code branch Aug 26, 2017

@kares kares added this to the JRuby 9.2.0.0 milestone Aug 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment