Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ji] make RubyIOs Java Closeable/Flushable + to_java to return stream #4758

Merged
merged 1 commit into from Aug 30, 2017

Conversation

@kares
Copy link
Member

@kares kares commented Aug 28, 2017

... also some minor improvements -> avoid converting to Java string

to_java(java.io.InputStream) returns the very same as the existing io.to_input_stream does

it just seems to make sense for the Java side of RubyIO to use it like a Closeable/Flushable object

... also some minor improvements -> avoid converting to Java string
@kares kares added this to the JRuby 9.2.0.0 milestone Aug 29, 2017
@kares kares merged commit 8c129de into master Aug 30, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kares kares deleted the ji-io-to-java branch Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.