New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ant DSL/wrapper from stdlib and replace with gem. #4811

Merged
merged 4 commits into from Oct 10, 2017

Conversation

Projects
None yet
1 participant
@headius
Member

headius commented Oct 10, 2017

This starts to address #2965. I have pulled the ant integration out of JRuby into a gem but it does not yet pull down Ant itself.

A few notes:

  • License is EPL 2
  • File structure has been updated to conform to namespacing norms (most stuff under rake/ant).
  • I had to include Rake::DSL into the toplevel of rake/ant/ant in order for bare calls to "tasks" and other top-level Rake DSL methods to work. There may be a cleaner way to make this work without polluting toplevel.
  • I'm not sure how best to pull down Ant. I assume it would be something in jar-dependencies but need help/advice from @mkristian here.

With the current pulled-out gem, we can build as normal and still run rake builds that (unfortunately) still depend on ant.

@headius headius merged commit 625fac9 into master Oct 10, 2017

0 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@headius headius deleted the remove-ant branch Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment