Fix spec of Thread#status for an externally killed thread that sleeps #4815
Conversation
There could be a race here, if a thread marks itself as aborting and then some other thread tries to exit sleep at the same time, but ideally exitSleep should only be called by that thread when it transitions. The uses I reviewed seem to fit that pattern. Worst case, some bad actor might cause an aborting thread to mark itself as runnable again. it would be no worse than now but less likely to happen. |
FWIW The way we do in in TruffleRuby is to save/restore the Thread status around sleep/blocking tasks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #4705