New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch ShellLauncher to use getAbsolutePath #4821

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@zendes

zendes commented Oct 18, 2017

I ran into some issues with using JRuby on a system that uses busybox as it's userland, and without this patch things won't work.

For a bit of background: busybox's goal is to be a tiny userland (commands like ls and mv) for space-constrained devices. One of the ways it does this is by being a multi-call binary. You symlink it with names such as ls and cp, and it uses $0 to determine how it's called and thus what it should do. JRuby resolves the symlink before it execs, so busybox loses $0 and thus doesn't know what the user originally called. This patch fixes that.

@zendes

This comment has been minimized.

Show comment
Hide comment
@zendes

zendes Oct 20, 2017

looks like the CI build failed in a bunch of places that are unrelated to my change, and it was also failing to build before my change. what do you need from me to look at this?

zendes commented Oct 20, 2017

looks like the CI build failed in a bunch of places that are unrelated to my change, and it was also failing to build before my change. what do you need from me to look at this?

@mullermp

This comment has been minimized.

Show comment
Hide comment
@mullermp

mullermp Oct 23, 2017

+1

I don't use busybox, but we do this same exact fix for a symlinking problem at my company.

mullermp commented Oct 23, 2017

+1

I don't use busybox, but we do this same exact fix for a symlinking problem at my company.

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Oct 23, 2017

Member

sounds like, this makes sense - maybe even to get into 9.1.14.0

Member

kares commented Oct 23, 2017

sounds like, this makes sense - maybe even to get into 9.1.14.0

@kares kares added this to the JRuby 9.1.14.0 milestone Oct 23, 2017

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Oct 30, 2017

Member

I'll merge this to 9.1.14 and master. Thanks for the help @zendes!

Member

headius commented Oct 30, 2017

I'll merge this to 9.1.14 and master. Thanks for the help @zendes!

@headius headius closed this Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment