New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BigDecimal::limit work for subtraction and division. Fix issue #1615 #4830

Merged
merged 2 commits into from Oct 30, 2017

Conversation

Projects
None yet
3 participants
@MrBerg
Contributor

MrBerg commented Oct 27, 2017

No description provided.

@headius headius added this to the JRuby 9.1.14.0 milestone Oct 30, 2017

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Oct 30, 2017

Member

👍 from me too. I'll merge to master and 9.1.

Member

headius commented Oct 30, 2017

👍 from me too. I'll merge to master and 9.1.

@headius headius merged commit 850a14b into jruby:master Oct 30, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@MrBerg MrBerg deleted the MrBerg:enforce-bigdecimal-limit branch Oct 30, 2017

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Oct 30, 2017

Member

Actually looks like there are other changes to BigDecimal on master that would need to be merged to jruby-9.1 first, like the divWithScale method. I'll try to sort it out.

Member

headius commented Oct 30, 2017

Actually looks like there are other changes to BigDecimal on master that would need to be merged to jruby-9.1 first, like the divWithScale method. I'll try to sort it out.

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Oct 30, 2017

Member

Merged into 9.1 as dc7b498 and 28eb942. The missing commit from master to make it merge nicely was f386054.

Member

headius commented Oct 30, 2017

Merged into 9.1 as dc7b498 and 28eb942. The missing commit from master to make it merge nicely was f386054.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment