New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3953] Use java.nio for FileTest#symlink? #4852

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@gerhardgruber
Contributor

gerhardgruber commented Nov 10, 2017

No description provided.

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Nov 10, 2017

where did saving and restoring of $! go ?

where did saving and restoring of $! go ?

This comment has been minimized.

Show comment
Hide comment
@gerhardgruber

gerhardgruber Nov 10, 2017

Do we still need it? I tried to figure out where $! could be modified in the new code, but didn't see where.
But if you say that we need id, I will put it in again...

gerhardgruber replied Nov 10, 2017

Do we still need it? I tried to figure out where $! could be modified in the new code, but didn't see where.
But if you say that we need id, I will put it in again...

This comment has been minimized.

Show comment
Hide comment
@kares

kares Nov 10, 2017

ah right I see - no RaiseException can happen - it should be fina, in that case. sorry for the false alarm

kares replied Nov 10, 2017

ah right I see - no RaiseException can happen - it should be fina, in that case. sorry for the false alarm

@headius headius added this to the JRuby 9.1.15.0 milestone Nov 12, 2017

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Nov 12, 2017

Member

This was pushed to 9.1 in 1bcf171 and master in 1bcf171. Thank you!

Member

headius commented Nov 12, 2017

This was pushed to 9.1 in 1bcf171 and master in 1bcf171. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment