Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix issues discovered using Error Prone #4860
This found a number of bugs (ranging in severity/nagginess). I'm happy to revert or change any of these, but all of them represent real defects:
RubyEnumerable - each_with_index19 is trivially infinitely-recursive. I assumed that each_with_index is appropriate
The ripper suggestion is wrong even though it did point out there was a bug there. These all look good except that one. That one should be something like:
StringBuilder buf = new StringBuilder(); buf.append((char) end);
@nglorioso change to that or omit that change otherwise I think it all looks good to me. Although I surprising bad at bit math stuff so the StructLayout change would be nice if someone else said that is ok.
About half reasonable changes, half unnecessary or incorrect.