Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Don't unconditionally emit debug level info from RACC #4881
In 3fe1cc2, jruby's version of racc/parser.rb was brought in line with MRI racc/parser.rb. This brought along a change to the yyparse method which changed the last argument from false to true. This causes the java racc parser implementation to unconditionally emit very noisy debug output whenever yyparse is called, where previously it would not emit such output. Passing true is safe for the pure ruby parser, as it ignores the argument entirely and does nothing with it. It is also safe for the native c parser, as that parser only emits debug info if it is compiled with DEBUG set. Tenderlove's version of racc disabled debug by default in ruby/racc@c5359ab, but it looks like MRI never picked up that change. For a time, true was passed and debugging info was not emitted (between 220.127.116.11 and 18.104.22.168). This was because in the merge to bring racc/parser.rb in line with MRI, the loading of the java cparse library no longer happened, so the pure ruby version of the library was used which ignores the debug parameter entirely. This changed in baeaad1 when the cparse-java.jar was being loaded again for jruby.