Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMiscellaneous parsing fixes #4911
Conversation
grddev
added some commits
Dec 19, 2017
enebo
added this to the JRuby 9.2.0.0 milestone
Dec 22, 2017
enebo
merged commit 9450508
into
jruby:master
Dec 22, 2017
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build failed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
grddev commentedDec 22, 2017
This addresses additional (beyond #4898) parsing inconsistencies between MRI and JRuby (and JRuby's main Ruby parser and Ripper parser).
The additional tests introduced did not pass in the original JRuby version(s), but did pass when running through MRI.