Make Kernel#pp available by default #4914
Merged
Conversation
For more information, please see feature #14123.
|
@nomadium "Note: the tests are copied from MRI." Which tests are you referring to? |
|
@olleolleolle It was a typo, sorry about that. I copy&pasted the body of another PR and forgot to remove the bit about the tests. I scanned MRI source code to verify if they were testing this new feature, but I couldn't find any tests, although my search was not exhaustive. So, that's the reason why I didn't include test. If they are needed, just let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi folks,
This is another feature targeting Ruby 2.5 [1]: Kernel#pp by default (feature #14123).
Note: the tests are copied from MRI.Thanks for your review and feedback.