New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Kernel#pp available by default #4914

Merged
merged 1 commit into from Jan 10, 2018

Conversation

Projects
None yet
4 participants
@nomadium
Contributor

nomadium commented Dec 28, 2017

Hi folks,

This is another feature targeting Ruby 2.5 [1]: Kernel#pp by default (feature #14123).

Note: the tests are copied from MRI.

Thanks for your review and feedback.

  1. #4876
Require Kernel#pp by default
For more information, please see feature #14123.
@olleolleolle

This comment has been minimized.

Contributor

olleolleolle commented Dec 28, 2017

@nomadium "Note: the tests are copied from MRI." Which tests are you referring to?

@nomadium

This comment has been minimized.

Contributor

nomadium commented Dec 28, 2017

@olleolleolle It was a typo, sorry about that. I copy&pasted the body of another PR and forgot to remove the bit about the tests.

I scanned MRI source code to verify if they were testing this new feature, but I couldn't find any tests, although my search was not exhaustive. So, that's the reason why I didn't include test. If they are needed, just let me know.

@kares kares added the ruby 2.5 label Dec 29, 2017

@enebo enebo added this to the JRuby 9.3.0.0 milestone Jan 10, 2018

@enebo enebo merged commit 7c6f524 into jruby:ruby-2.5 Jan 10, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@nomadium nomadium deleted the nomadium:require-pp-in-kernel branch Jan 10, 2018

@enebo enebo modified the milestones: JRuby 9.3.0.0, JRuby 9.2.0.0 Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment