Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMake Kernel#pp available by default #4914
Conversation
This comment has been minimized.
This comment has been minimized.
|
@nomadium "Note: the tests are copied from MRI." Which tests are you referring to? |
This comment has been minimized.
This comment has been minimized.
|
@olleolleolle It was a typo, sorry about that. I copy&pasted the body of another PR and forgot to remove the bit about the tests. I scanned MRI source code to verify if they were testing this new feature, but I couldn't find any tests, although my search was not exhaustive. So, that's the reason why I didn't include test. If they are needed, just let me know. |
kares
added
the
ruby 2.5
label
Dec 29, 2017
enebo
added this to the JRuby 9.3.0.0 milestone
Jan 10, 2018
enebo
merged commit 7c6f524
into
jruby:ruby-2.5
Jan 10, 2018
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build could not complete due to an error
Details
nomadium
deleted the
nomadium:require-pp-in-kernel
branch
Jan 10, 2018
enebo
modified the milestones:
JRuby 9.3.0.0,
JRuby 9.2.0.0
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nomadium commentedDec 28, 2017
•
edited
Hi folks,
This is another feature targeting Ruby 2.5 [1]: Kernel#pp by default (feature #14123).
Note: the tests are copied from MRI.Thanks for your review and feedback.