Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test undef #4924

Merged
merged 3 commits into from Jan 2, 2018
Merged

Fix test undef #4924

merged 3 commits into from Jan 2, 2018

Conversation

@yui-knk
Copy link
Contributor

@yui-knk yui-knk commented Dec 31, 2017

Fix a warning message
In MRI, this warning is

  -e:1: warning: undefining `object_id' may cause serious problems

Remove __id__ from warning targets
__id__ is not listed on warning targets in MRI.

yui-knk added 3 commits Dec 31, 2017
In MRI, this warning is

```
-e:1: warning: undefining `object_id' may cause serious problems
```
By this commit `TestModule#test_undef` will be passed.
`__id__` is not listed on warning targets in MRI.
@kares kares merged commit 1534e7f into jruby:master Jan 2, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@kares
Copy link
Member

@kares kares commented Jan 2, 2018

makes sense - nice work, the cross-reference made it clear (wasn't sure where exactly to double check)

@kares kares added this to the JRuby 9.2.0.0 milestone Jan 2, 2018
@yui-knk yui-knk deleted the yui-knk:fix_test_undef branch Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.