/jruby

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise `TypeError` if `module_function` is not called for modules #4927

Merged
merged 1 commit into from Jan 2, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  JRuby 9.2.0.0
2 participants
@yui-knk @enebo
@yui-knk
Contributor

yui-knk commented Dec 31, 2017

For example, these code calls module_function for Class:

Module.instance_method(:module_function).bind(Class.new).call(:foo)

This commit will fix TestClass#test_module_function.
@yui-knk
Raise `TypeError` if `module_function` is not called for modules 
For example, these code calls module_function for Class:

```
Module.instance_method(:module_function).bind(Class.new).call(:foo)
```

This commit will fix `TestClass#test_module_function`.
227a8a2

@enebo enebo added this to the JRuby 9.2.0.0 milestone Jan 2, 2018

@enebo enebo merged commit 7c77dbb into jruby:master Jan 2, 2018
1 check failed

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@yui-knk yui-knk deleted the yui-knk:test_module_function branch Jan 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment