New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Array#prepend and Array#append aliases #4935

Merged
merged 1 commit into from Jan 4, 2018

Conversation

Projects
None yet
2 participants
@ChrisBr
Contributor

ChrisBr commented Jan 4, 2018

to support Ruby 2.5, see https://bugs.ruby-lang.org/issues/12746.
#4876

It seems like tests already existed in
spec/ruby/core/array/append_spec.rb and spec/ruby/core/array/prepend_spec.rb

Supersedes #4934

@enebo enebo added this to the JRuby 9.3.0.0 milestone Jan 4, 2018

@enebo enebo merged commit 425743f into jruby:ruby-2.5 Jan 4, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@enebo

This comment has been minimized.

Member

enebo commented Jan 4, 2018

@ChrisBr thanks for digging in!

@enebo enebo modified the milestones: JRuby 9.3.0.0, JRuby 9.2.0.0 Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment