Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement Dir.glob base option #4936
Conversation
| dirs = new ArrayList<ByteList>(); | ||
| } else if (tmp.isNil()) { | ||
| dir = base.isEmpty() ? runtime.getCurrentDirectory() : base; | ||
| dirs = Dir.push_glob(runtime, dir, globArgumentAsByteList(context, args[0]), flags); |
This comment has been minimized.
This comment has been minimized.
ChrisBr
Jan 5, 2018
Contributor
Wondering what the difference between runtime.getCurrentDirectory() and getCWD(runtime) or is it possible to simplify the code and only use either or?
This comment has been minimized.
This comment has been minimized.
enebo
Jan 5, 2018
Member
@ChrisBr getCWD will force canonicalization whereas runtime.getCurrentDirectory is whatever it was set to (which might have already been canonicalized). Even if we happen to always canon. the stored value getCWD always tries to do it again (unless it is an URI).
Dir.glob is a dirty beast and I do not remember what contract it has for the incoming directory but that would be the proper guidance on which to use.
enebo
added this to the JRuby 9.3.0.0 milestone
Jan 5, 2018
enebo
merged commit 4e6b330
into
jruby:ruby-2.5
Jan 5, 2018
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build could not complete due to an error
Details
added a commit
to ChrisBr/jruby
that referenced
this pull request
Jan 6, 2018
ChrisBr
referenced this pull request
Jan 6, 2018
Merged
Fix NullPointerException when option is not :base #4946
added a commit
to ChrisBr/jruby
that referenced
this pull request
Jan 9, 2018
enebo
modified the milestones:
JRuby 9.3.0.0,
JRuby 9.2.0.0
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ChrisBr commentedJan 4, 2018
https://bugs.ruby-lang.org/issues/13056
Tests c&p from ruby/ruby@52419a6.
#4876