Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Dir.children #4941

Merged
merged 3 commits into from Jan 5, 2018

Conversation

Projects
None yet
3 participants
@nomadium
Copy link
Contributor

nomadium commented Jan 5, 2018

Hi folks,

This is another feature targeting Ruby 2.5 [1]: Dir.children (feature #11302).

Notes:

  • The tests are copied from MRI.
  • I also cherry-picked a commit [2] from master to be able to use Java8 lambda expressions. If that's not OK, this PR could wait until that change is merged in ruby-2.5 branch; if this is the right approach, of course.

Thanks for your review and feedback.

  1. #4876
  2. 12b9f0f

headius and others added some commits Jan 3, 2018

Implement Dir.children
For more information, please see feature #11302.

@enebo enebo added this to the JRuby 9.3.0.0 milestone Jan 5, 2018

@enebo enebo merged commit b9c1195 into jruby:ruby-2.5 Jan 5, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@nomadium nomadium deleted the nomadium:implement-dir-children branch Jan 10, 2018

@enebo enebo modified the milestones: JRuby 9.3.0.0, JRuby 9.2.0.0 Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.