New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullPointerException when option is not :base #4946

Merged
merged 1 commit into from Jan 8, 2018

Conversation

Projects
None yet
2 participants
@ChrisBr
Contributor

ChrisBr commented Jan 6, 2018

now it throws an ArgumentError like it does in MRI.
Introduced in #4936.

Fix NullPointerException when option is not :base
now it throws an ArgumentError like it does in MRI.
Introduced in #4936.

@enebo enebo added this to the JRuby 9.3.0.0 milestone Jan 8, 2018

@enebo enebo merged commit f5ef5ac into jruby:ruby-2.5 Jan 8, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@enebo

This comment has been minimized.

Member

enebo commented Jan 8, 2018

@ChrisBr Now that you fixed this I suspect you are missing another Hash type check if arity == 3. Trying passing in a Fixnum as arg three...

@enebo enebo modified the milestones: JRuby 9.3.0.0, JRuby 9.2.0.0 Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment