Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RubyHash to pass `#test_create` #4947

Merged
merged 3 commits into from Jan 8, 2018

Conversation

Projects
None yet
2 participants
@yui-knk
Copy link
Contributor

yui-knk commented Jan 6, 2018

Warn if wrong type elements are passed to Hash.[]
Ref: https://github.com/ruby/ruby/blob/v2_4_0/hash.c#L693-L696

Raise ArgumentError when invalid number of elements are passed to Hash.[]
Ref: https://github.com/ruby/ruby/blob/v2_4_0/hash.c#L701-L703

@enebo enebo added this to the JRuby 9.2.0.0 milestone Jan 8, 2018

@enebo enebo merged commit 2e8201f into jruby:master Jan 8, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@yui-knk yui-knk deleted the yui-knk:Hash_test_create branch Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.