New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `Hash#reject` #4951

Merged
merged 1 commit into from Jan 8, 2018

Conversation

Projects
None yet
2 participants
@yui-knk
Contributor

yui-knk commented Jan 8, 2018

In MRI, Hash#reject

  • creates new hash
  • sets keys & values if block returns false

This commit will fix #test_reject.

Ref: https://github.com/ruby/ruby/blob/v2_4_0/hash.c#L1328

Fix `Hash#reject`
In MRI, `Hash#reject`

* creates new hash
* sets keys & values if block returns false

This commit will fix `#test_reject`.

Ref: https://github.com/ruby/ruby/blob/v2_4_0/hash.c#L1328

@enebo enebo added this to the JRuby 9.2.0.0 milestone Jan 8, 2018

@enebo enebo merged commit 9504a1c into jruby:master Jan 8, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@enebo

This comment has been minimized.

Member

enebo commented Jan 8, 2018

@yui-knk if you realize some of these are also fixes for Ruby 2.3 support I encourage you to submit PRs in those cases against jruby-9.1 branch. We will merge that branch back to master so both releases get the same fixes.

@yui-knk

This comment has been minimized.

Contributor

yui-knk commented Jan 8, 2018

I see, thank you for your advice!

@yui-knk yui-knk deleted the yui-knk:test_reject branch Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment