Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement Dir.each_child #4953
Conversation
nomadium
added some commits
Jan 5, 2018
| RubyClass dirClass = runtime.getDir(); | ||
| RubyDir dir = (RubyDir) dirClass.newInstance(context, new IRubyObject[]{_path}, block); | ||
| dir.each_child(context, block); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nomadium
Jan 10, 2018
Contributor
Good observation. I'm not really sure about MRI on this, but Dir::foreach JRuby method implementation is currently doing something similar if I'm not mistaken: https://github.com/jruby/jruby/blob/ruby-2.5/core/src/main/java/org/jruby/RubyDir.java#L481
I'll get back to this later with my findings.
enebo
merged commit 19a43e1
into
jruby:ruby-2.5
Jan 10, 2018
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build could not complete due to an error
Details
nomadium
deleted the
nomadium:implement-dir-each-child
branch
Jan 10, 2018
enebo
added this to the JRuby 9.3.0.0 milestone
Feb 21, 2018
enebo
modified the milestones:
JRuby 9.3.0.0,
JRuby 9.2.0.0
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nomadium commentedJan 8, 2018
Hi folks,
This is another feature targeting Ruby 2.5 [1]: Dir.each_child (feature #11302).
Note: The test is copied from MRI.
Thanks for your review and feedback.