Skip to content

/ jruby

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alias Set#=== to #include? #4954

Merged
merged 3 commits into from Jan 10, 2018
Merged

Alias Set#=== to #include? #4954

merged 3 commits into from Jan 10, 2018

Conversation

@ChrisBr
Copy link
Contributor

@ChrisBr ChrisBr commented Jan 8, 2018

tests cherry picked from ruby/ruby@2aee703.
Feature https://bugs.ruby-lang.org/issues/13801.
@kares
Copy link
Member

@kares kares commented Jan 9, 2018

👍 najs job, one minor detail related to adding into spec/ruby/...` they're merged/picked back-and-forth to the canonical ruby/spec repo

try to introduce changes in there in separate commits so they can be picked easily ...
@kares kares added this to the JRuby 9.3.0.0 milestone Jan 9, 2018
ChrisBr added 3 commits Jan 9, 2018
@ChrisBr
Add specs for alias Set#=== to #include?
Unverified
The committer email address is not verified.
Learn about signing commits
9922da3 
from 2aee703e7a29bcfc2095e40870f5a3c45cd96dd2.
@ChrisBr
Add MRI test for alias Set#=== to include?
Unverified
The committer email address is not verified.
Learn about signing commits
2f7d4ff 
from 2aee703e7a29bcfc2095e40870f5a3c45cd96dd2.
@ChrisBr
Alias Set#=== to include?
Unverified
The committer email address is not verified.
Learn about signing commits
Loading status checks…
2799bfe 
Feature https://bugs.ruby-lang.org/issues/13801.
#4876.
@ChrisBr ChrisBr force-pushed the ChrisBr:feature/set-equal branch from fef7d0b to 2799bfe Jan 9, 2018
@ChrisBr
Copy link
Contributor Author

@ChrisBr ChrisBr commented Jan 9, 2018

@kares splitted into three different commits now!
@kares kares merged commit 153f623 into jruby:ruby-2.5 Jan 10, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@enebo enebo modified the milestones: JRuby 9.3.0.0, JRuby 9.2.0.0 Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ruby 2.5 stdlib
Projects
None yet
Milestone
JRuby 9.2.0.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@ChrisBr @kares @enebo
You can’t perform that action at this time.