New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias Set#=== to #include? #4954

Merged
merged 3 commits into from Jan 10, 2018

Conversation

Projects
None yet
3 participants
@ChrisBr
Contributor

ChrisBr commented Jan 8, 2018

tests cherry picked from ruby/ruby@2aee703.
Feature https://bugs.ruby-lang.org/issues/13801.

@kares

This comment has been minimized.

Member

kares commented Jan 9, 2018

👍 najs job, one minor detail related to adding into spec/ruby/...` they're merged/picked back-and-forth to the canonical ruby/spec repo

try to introduce changes in there in separate commits so they can be picked easily ...

@kares kares added this to the JRuby 9.3.0.0 milestone Jan 9, 2018

ChrisBr added some commits Jan 9, 2018

Add specs for alias Set#=== to #include?
from 2aee703e7a29bcfc2095e40870f5a3c45cd96dd2.
Add MRI test for alias Set#=== to include?
from 2aee703e7a29bcfc2095e40870f5a3c45cd96dd2.
@ChrisBr

This comment has been minimized.

Contributor

ChrisBr commented Jan 9, 2018

@kares splitted into three different commits now!

@kares kares merged commit 153f623 into jruby:ruby-2.5 Jan 10, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@enebo enebo modified the milestones: JRuby 9.3.0.0, JRuby 9.2.0.0 Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment