Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hash#rehash method for duplicate keys #4961

Merged
merged 2 commits into from Jan 10, 2018
Merged

Conversation

@ChrisBr
Copy link
Contributor

@ChrisBr ChrisBr commented Jan 9, 2018

Duplicate keys where just ignored before and inserted again.
Fix #4958.

@kares
Copy link
Member

@kares kares commented Jan 10, 2018

@ChrisBr how's that separate commits with changes under spec/ruby, do we need a 🐩 bot around :) ?

ChrisBr added 2 commits Jan 10, 2018
Duplicate keys where just ignored before and inserted again.
Fix #4958.
@ChrisBr ChrisBr force-pushed the ChrisBr:bug/rehash branch from da6ad39 to 2a7d600 Jan 10, 2018
@ChrisBr
Copy link
Contributor Author

@ChrisBr ChrisBr commented Jan 10, 2018

@kares splitted

@headius
Copy link
Member

@headius headius commented Jan 10, 2018

👍

@headius headius merged commit 80efaf4 into jruby:master Jan 10, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@headius headius added this to the JRuby 9.2.0.0 milestone Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants