Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix Hash#rehash method for duplicate keys #4961
Conversation
This comment has been minimized.
This comment has been minimized.
|
@ChrisBr how's that separate commits with changes under spec/ruby, do we need a |
ChrisBr
added some commits
Jan 10, 2018
This comment has been minimized.
This comment has been minimized.
|
@kares splitted |
This comment has been minimized.
This comment has been minimized.
|
|
headius
merged commit 80efaf4
into
jruby:master
Jan 10, 2018
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build could not complete due to an error
Details
headius
added this to the JRuby 9.2.0.0 milestone
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ChrisBr commentedJan 9, 2018
Duplicate keys where just ignored before and inserted again.
Fix #4958.