Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/string casecmp #4975

Merged
merged 2 commits into from Jan 15, 2018
Merged

Feature/string casecmp #4975

merged 2 commits into from Jan 15, 2018

Conversation

@ChrisBr
Copy link
Contributor

@ChrisBr ChrisBr commented Jan 14, 2018

to return nil for incompatible types instead of raising exception.
Support for Ruby 2.5

See feature https://bugs.ruby-lang.org/issues/13312.

@lopex
Copy link
Member

@lopex lopex commented Jan 14, 2018

@ChrisBr if checkStringType doesnt return nil you can safely cast it to RubyString, otherwise you're doing the conversion twice here by calling convertToString.

@ChrisBr ChrisBr force-pushed the ChrisBr:feature/string-casecmp branch from 1323239 to 002e2c4 Jan 14, 2018
ChrisBr added 2 commits Jan 14, 2018
@ChrisBr ChrisBr force-pushed the ChrisBr:feature/string-casecmp branch from 002e2c4 to bdd7b2f Jan 14, 2018
@ChrisBr
Copy link
Contributor Author

@ChrisBr ChrisBr commented Jan 14, 2018

@lopex you're right, fixed

@ChrisBr
Copy link
Contributor Author

@ChrisBr ChrisBr commented Jan 14, 2018

Please note that the casecmp? test is excluded from the test suite because of missing case-fold logic

@enebo enebo added this to the JRuby 9.3.0.0 milestone Jan 15, 2018
@enebo enebo merged commit fb79687 into jruby:ruby-2.5 Jan 15, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@enebo enebo modified the milestones: JRuby 9.3.0.0, JRuby 9.2.0.0 Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.