/jruby

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String#-@ deduplicates unfrozen strings #4983

Merged
merged 2 commits into from Jan 17, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
  JRuby 9.2.0.0
3 participants
@ChrisBr @kares @enebo
@ChrisBr
Contributor

ChrisBr commented Jan 16, 2018

For Ruby 2.5 support
https://bugs.ruby-lang.org/issues/13077

ChrisBr added some commits Jan 16, 2018

@ChrisBr
String#-@ deduplicates unfrozen strings 
Already-frozen strings remain unchanged for compatibility.
https://bugs.ruby-lang.org/issues/13077
#4876.
Verified
This commit was signed with a verified signature.
@ChrisBr ChrisBr Christian Bruckmayer
GPG key ID: 168295FC108C44E5 Learn about signing commits
8a8fdc0
@ChrisBr
Tests for String#@- deduplicates strings 
c&p from 15ef28a991f66f65bb29751cf2bef3bcb51066fc.
#4876
Verified
This commit was signed with a verified signature.
@ChrisBr ChrisBr Christian Bruckmayer
GPG key ID: 168295FC108C44E5 Learn about signing commits
4b0f4c0

@kares kares added this to the JRuby 9.3.0.0 milestone Jan 17, 2018

@kares kares added core ruby 2.5 labels Jan 17, 2018

@kares kares merged commit aeeff9f into jruby:ruby-2.5 Jan 17, 2018
1 check was pending

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@enebo enebo modified the milestones: JRuby 9.3.0.0, JRuby 9.2.0.0 Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment