Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCheck an encoding of string #4992
Conversation
enebo
added this to the JRuby 9.1.16.0 milestone
Jan 20, 2018
enebo
merged commit 2666447
into
jruby:jruby-9.1
Jan 20, 2018
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build could not complete due to an error
Details
This comment has been minimized.
This comment has been minimized.
|
A recent java 9 change has made seeing results of this difficult but it looks reasonable. |
yui-knk
deleted the
yui-knk:fix_test_symbol_encoding
branch
Jan 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
yui-knk commentedJan 20, 2018
MRI checks an encoding of string is broken
before conveting string to symbol.
This commit will fix
#test_symbol_encoding.Ref: https://github.com/ruby/ruby/blob/v2_5_0/symbol.c#L432