Check an encoding of string #4992
Merged
Conversation
MRI checks an encoding of string is broken before conveting string to symbol. This commit will fix `#test_symbol_encoding`. Ref: https://github.com/ruby/ruby/blob/v2_5_0/symbol.c#L432
|
A recent java 9 change has made seeing results of this difficult but it looks reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MRI checks an encoding of string is broken
before conveting string to symbol.
This commit will fix
#test_symbol_encoding.Ref: https://github.com/ruby/ruby/blob/v2_5_0/symbol.c#L432