New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TestArray#test_zip exclusion test case #5011

Merged
merged 1 commit into from Jan 29, 2018

Conversation

Projects
None yet
3 participants
@nomadium
Contributor

nomadium commented Jan 25, 2018

Hi folks,

I noticed the assertion in the excluded test test_zip at https://github.com/jruby/jruby/blob/master/test/mri/ruby/test_array.rb#L2223 was raising a NoMethodError instead of the expected TypeError.

With this proposed change, if correct, the test should pass.

Thanks for your review and feedback.

@olleolleolle

This comment has been minimized.

Contributor

olleolleolle commented Jan 26, 2018

@nomadium These changes you make are great!

ruby/ruby cross-reference links:

@enebo enebo added this to the JRuby 9.2.0.0 milestone Jan 29, 2018

@enebo enebo merged commit 63821af into jruby:master Jan 29, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@enebo

This comment has been minimized.

Member

enebo commented Jan 29, 2018

@olleolleolle thanks for finding that respond_to? reference. I only paused in merging this one before because I thought, "wow..a respond_to? per element".

@nomadium nomadium deleted the nomadium:fix-array-test-zip-exclude branch Jan 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment