Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude `#test_windows_1255` from our tests #5016

Merged
merged 1 commit into from Jan 29, 2018

Conversation

Projects
None yet
3 participants
@yui-knk
Copy link
Contributor

yui-knk commented Jan 27, 2018

We use jcodings 1.0.27 which maps
windows-1255 0xCA to UTF-8 U+05BA.
But this had been supported since CRuby 2.4.

Ref: ruby/ruby@b24e093

Exclude `#test_windows_1255` from our tests
We use jcodings 1.0.27 which maps
windows-1255 0xCA to UTF-8 U+05BA.
But this had been supported since CRuby 2.4.

Ref: ruby/ruby@b24e093
@lopex

This comment has been minimized.

Copy link
Member

lopex commented Jan 27, 2018

It must be this update then: jruby/jcodings@5f77b82.
@headius: https://github.com/ruby/ruby/blob/v2_4_3/test/ruby/test_transcode.rb#L366 doesnt seem to be expecting any errors here.

@enebo

This comment has been minimized.

Copy link
Member

enebo commented Jan 29, 2018

@lopex @headius what is the appropriate thing to do here? Looks like they fixed an issue which presumably means this test was incorrect for 2.3.x?

@enebo enebo added this to the JRuby 9.1.16.0 milestone Jan 29, 2018

@enebo enebo merged commit 323169c into jruby:jruby-9.1 Jan 29, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@yui-knk yui-knk deleted the yui-knk:test_windows_1255 branch Jan 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.