No longer hide exceptions from coerce method #5025
Merged
Conversation
…tors (< ,<=, >=, >) For more information, please see feature #7688.
… which cannot be compared with #> to 0 For more information, please see feature #7688.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi folks,
This is another feature targeting Ruby 2.5 [1]:
Numerical comparison operators (< ,<=, >=, >) no longer rescue exceptions of #coerce. Return nil in #coerce if the coercion is impossible.
Integer#step does no longer rescue exceptions when given a step value which cannot be compared with #> to 0.
Range#initialize no longer rescue exceptions when comparing begin and end with #<=> and raise a "bad value for range" ArgumentError but instead let the exception from the #<=> call go through.
All of these from feature #7688 [2].
Note: The tests are copied from MRI.
Thanks for your review and feedback.