New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix String#rpartition for RegEx on Strings with multibyte chars #5026

Merged
merged 1 commit into from Feb 1, 2018

Conversation

Projects
None yet
2 participants
@ChrisBr
Contributor

ChrisBr commented Feb 1, 2018

because before it used the wrong index when there was a mulitbyte character in the string.
We now let handle rindex function the index detection.

Fix String#rpartition for RegEx on Strings with multibyte chars
because before it used the wrong index when there was a mulitbyte character in the string.
We now let handle rindex function the index detection.

@enebo enebo added this to the JRuby 9.2.0.0 milestone Feb 1, 2018

@enebo enebo merged commit f8de9a0 into jruby:master Feb 1, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment